From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627AbcGUVmK (ORCPT ); Thu, 21 Jul 2016 17:42:10 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:36736 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754526AbcGUVmG (ORCPT ); Thu, 21 Jul 2016 17:42:06 -0400 Date: Thu, 21 Jul 2016 17:42:02 -0400 From: Tejun Heo To: Tom Yan Cc: Hannes Reinecke , Sergei Shtylyov , Arnd Bergmann , Stephen Rothwell , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH resend 3/5] libata-scsi: fix overflow in mode page copy Message-ID: <20160721214202.GG23759@htj.duckdns.org> References: <20160721211714.GE23759@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2016 at 05:39:27AM +0800, Tom Yan wrote: > Let me know how I should polish the description for this. The above is because the signed ones are getting sign-extended making them different from the unsigned ones which don't get padded in the high bits. Converting to u8 is the right thing to do but nothing here is getting truncated. Thanks. -- tejun