From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbcGVIhn (ORCPT ); Fri, 22 Jul 2016 04:37:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53147 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbcGVIhk (ORCPT ); Fri, 22 Jul 2016 04:37:40 -0400 Date: Fri, 22 Jul 2016 10:37:36 +0200 From: Benjamin Tissoires To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Jiri Kosina , linux-input@vger.kernel.org Subject: Re: [PATCH v2] HID: use IS_ENABLED() instead of checking for built-in or module Message-ID: <20160722083736.GA19383@mail.corp.redhat.com> References: <1469114754-2650-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1469114754-2650-1-git-send-email-javier@osg.samsung.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 22 Jul 2016 08:37:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jul 21 2016 or thereabouts, Javier Martinez Canillas wrote: > The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > built-in or as a module, use that macro instead of open coding the same. > > Using the macro makes the code more readable by helping abstract away some > of the Kconfig built-in and module enable details. > > Signed-off-by: Javier Martinez Canillas > > --- Reviewed-by: Benjamin Tissoires Cheers, Benjamin > > Changes in v2: > - Post correct patch since v1 got mangled by the MTA. > > drivers/hid/hid-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 08f53c7fd513..386f31481c06 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -2480,7 +2480,7 @@ static const struct hid_device_id hid_ignore_list[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_PANJIT, 0x0004) }, > { HID_USB_DEVICE(USB_VENDOR_ID_PHILIPS, USB_DEVICE_ID_PHILIPS_IEEE802154_DONGLE) }, > { HID_USB_DEVICE(USB_VENDOR_ID_POWERCOM, USB_DEVICE_ID_POWERCOM_UPS) }, > -#if defined(CONFIG_MOUSE_SYNAPTICS_USB) || defined(CONFIG_MOUSE_SYNAPTICS_USB_MODULE) > +#if IS_ENABLED(CONFIG_MOUSE_SYNAPTICS_USB) > { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP) }, > { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_INT_TP) }, > { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_CPAD) }, > -- > 2.5.5 >