From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752283AbcGVTQ0 (ORCPT ); Fri, 22 Jul 2016 15:16:26 -0400 Received: from mail.osadl.at ([92.243.35.153]:60668 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbcGVTQZ (ORCPT ); Fri, 22 Jul 2016 15:16:25 -0400 X-Greylist: delayed 435 seconds by postgrey-1.27 at vger.kernel.org; Fri, 22 Jul 2016 15:16:24 EDT Date: Fri, 22 Jul 2016 19:08:39 +0000 From: Nicholas Mc Guire To: Julia Lawall Cc: Nicholas Mc Guire , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] coccinelle: tests: if and else branch should probably not be identical Message-ID: <20160722190839.GA15538@osadl.at> References: <1469178343-29192-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2016 at 06:56:47PM +0200, Julia Lawall wrote: > > +virtual context > > +virtual org > > +virtual report > > + > > +@cond@ > > +statement S1; > > +position p; > > +@@ > > + > > +<+... > > +* if@p (...) S1 else S1 > > +...+> > > You don't need the <+... ...+>. Just put the if by itself. > will drop that then - though those would be needed for the cases that do this recursively. Will fix it and resend. thx! hofrat