From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbcGXQ5G (ORCPT ); Sun, 24 Jul 2016 12:57:06 -0400 Received: from resqmta-ch2-06v.sys.comcast.net ([69.252.207.38]:44146 "EHLO resqmta-ch2-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbcGXQ5D (ORCPT ); Sun, 24 Jul 2016 12:57:03 -0400 Date: Sun, 24 Jul 2016 09:54:59 -0700 From: "W. Trevor King" To: Andrey Vagin Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, criu@openvz.org, linux-fsdevel@vger.kernel.org, "Eric W. Biederman" , James Bottomley , "Michael Kerrisk (man-pages)" , Alexander Viro , Serge Hallyn Subject: Re: [PATCH 2/5] kernel: add a helper to get an owning user namespace for a namespace Message-ID: <20160724165459.GA5395@odin.tremily.us> References: <1468548742-32136-1-git-send-email-avagin@openvz.org> <1468548742-32136-2-git-send-email-avagin@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: <1468548742-32136-2-git-send-email-avagin@openvz.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.23 (2014-03-12) X-CMAE-Envelope: MS4wfIO30kSzk07n/IJulCtGrHyA97lfshSZVHBxo69PMMK4ZbvDCM1BXfJUoenHFRhQCXdIxG51jW/4RiDnliE7g19tkM6SzVZYCJGdQl3nczdiKI9sTQnL w7MozJiUwDexIhvUG4qoLEN1/4GEOC7GXP06VRLN1WAI+swODNwEU5wYPZlWmzvKuFPgRVGmP0HfFaUJbqcc8PwJcMQ1ib7Oz7RZ/n66AVJzrDjxtwdRdVLX yjvC6S0k07wKqISiTUjNRQPi8CMZ+KMUPLLCqU/FxAoaZ4TUJSpvzoYd7pTP4kq4CPE9YRWUiQKxbGKWuHv8RNkZP43lI7/Cb1jfLXWoDBzvQ85i+/ibPi4G qp7dMROTIVWE6d1qXT38OtiZPZTiTb78AG3IkKr1tJZmRv63igMy0QAZhhk05H5tBNcuRmvbDcjRUnrOt2Ng5dttHptsEnmTlzawPphhy+wHnA/RVu1tFEU4 /hQS5XYr461PzdC8ieuNPWyVZkCCLAdbdIOA/G4uA++UedLW1QhMGoHGFAyzYDtypAIRDsSRIHvdt9zXGB8LxeY5mAV7uC83H+nLNA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 14, 2016 at 07:12:19PM -0700, Andrey Vagin wrote: > +struct ns_common *ns_get_owner(struct ns_common *ns) > +{ > + =E2=80=A6 > + return &get_user_ns(user_ns)->ns; > +} Is there a reason to return the generic =E2=80=98struct ns_common *=E2=80= =99 here instead of =E2=80=98struct user_namespace *=E2=80=99? The current use case= doesn't need access to the additional information, but future ng_get_owner callers might, and we know the returned namespace (if any) will be a user namespace. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJXlPLgAAoJEBBpoQVgXJg1Y+YQAL53v01sQLz6ZMYNO3EU7QH0 Qdlqm6Pnm1i24HaSIbfLdJwcgMGYZ+Xll2QdkzAtF7R21oCt9nW0qqQ/LTx+opwK TNURnCw2wTcwEJSVaKm9cn9Amiu3GNxSYpGMB04VWA9eQYhXwlfdBLH3fBdP1/Gv Nad9n03/n2UOkKp4YSlWYT8BKb5GMAL05P0Ovkfh2KodEEN2xV0b6JmCq25fN5Jz WF4ynuMjoR7PaGzJPA2fKeiSNJAnOanNFuu8mhEkf6EpHgo17MQRDK4uYKpisJTt q075IpUFnlacrAwPpvy3TYWZjvsd0NxQFFdrr1/dx1+yJNEOB8zwCwrfu7Zz9D0O d4fveKTZF41JJcwHeJ0g8bt4TTdG9E0TBxAZS3mGcxC9/+kycXlqWF9si1z2ZSpL 7SyyjV9p2Su/1iG/GpHlGJXr+2/6xnfOySSyrwt/a2oLVb+Go99V1fLwHSESmtiV RfKt4yYqL0lEJJ76OC2b/UwXh3SBhcZOHf2oAQj5G7KN3Kjmp0oXYTKmzQzzNYTt DmenCSravlhiRIRnzspC1p6M4+7pkGwglcLuLzVynvFp3F/fX8NB/zf0xOc1BZEn 60fi38m6UJHDYy7FPtGEbf9EBFAi/Q+hPwd3ew1/+WBrueb0ziMD2UAfarKfV+j5 /0xOtmRqhQVkSIqpq7qr =ZWqH -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--