From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756050AbcGZAhI (ORCPT ); Mon, 25 Jul 2016 20:37:08 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49060 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756011AbcGZAhE (ORCPT ); Mon, 25 Jul 2016 20:37:04 -0400 Date: Mon, 25 Jul 2016 17:37:01 -0700 (PDT) Message-Id: <20160725.173701.1282720667210726281.davem@davemloft.net> To: decui@microsoft.com Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, vkuznets@redhat.com, cavery@redhat.com, kys@microsoft.com, joe@perches.com, rolf.neugebauer@docker.com, mkubecek@suse.cz, haiyangz@microsoft.com, dave.scott@docker.com Subject: Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Jul 2016 17:37:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dexuan Cui Date: Sat, 23 Jul 2016 01:35:51 +0000 > +static struct sock *hvsock_create(struct net *net, struct socket *sock, > + gfp_t priority, unsigned short type) > +{ > + struct hvsock_sock *hvsk; > + struct sock *sk; > + > + sk = sk_alloc(net, AF_HYPERV, priority, &hvsock_proto, 0); > + if (!sk) > + return NULL; ... > + /* Looks stream-based socket doesn't need this. */ > + sk->sk_backlog_rcv = NULL; > + > + sk->sk_state = 0; > + sock_reset_flag(sk, SOCK_DONE); All of these are unnecessary initializations, since sk_alloc() zeroes out the 'sk' object for you.