From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbcGZEjw (ORCPT ); Tue, 26 Jul 2016 00:39:52 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52206 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798AbcGZEjt (ORCPT ); Tue, 26 Jul 2016 00:39:49 -0400 Date: Mon, 25 Jul 2016 21:39:48 -0700 (PDT) Message-Id: <20160725.213948.1597000820762206692.davem@davemloft.net> To: bhaktipriya96@gmail.com Cc: dmitry.tarnyagin@lockless.no, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tj@kernel.org Subject: Re: [PATCH] caif-hsi: Remove deprecated create_singlethread_workqueue From: David Miller In-Reply-To: <20160725131057.GA751@Karyakshetra> References: <20160725131057.GA751@Karyakshetra> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Jul 2016 21:39:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhaktipriya Shridhar Date: Mon, 25 Jul 2016 18:40:57 +0530 > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since the workitems are being used > on a packet tx/rx path. Hence, WQ_MEM_RECLAIM has been set to guarantee > forward progress under memory pressure. > > An ordered workqueue has been used since workitems &cfhsi->wake_up_work > and &cfhsi->wake_down_work cannot be run concurrently. > > Calls to flush_workqueue() before destroy_workqueue() have been dropped > since destroy_workqueue() itself calls drain_workqueue() which flushes > repeatedly till the workqueue becomes empty. > > Signed-off-by: Bhaktipriya Shridhar Applied.