From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbcGYFph (ORCPT ); Mon, 25 Jul 2016 01:45:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:46631 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbcGYFp2 (ORCPT ); Mon, 25 Jul 2016 01:45:28 -0400 Date: Mon, 25 Jul 2016 07:45:25 +0200 From: Michal Kubecek To: Jiri Slaby Cc: Greg KH , Jiri Slaby , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Westphal , Pablo Neira Ayuso Subject: Re: [PATCH 3.12 28/88] netfilter: x_tables: validate targets of jumps Message-ID: <20160725054525.GA8749@unicorn.suse.cz> References: <3d4036cb9b963cdd270c02856a888183da0623db.1468483951.git.jslaby@suse.cz> <42b891251b3b9f241fb5f0a90e87b15d2fef0a74.1468483951.git.jslaby@suse.cz> <8d66c06f-7633-357e-f091-c182d78fb219@gmail.com> <20160721185633.GA24661@kroah.com> <769ca2fb-b99c-a6a4-2559-5c12887d5e8a@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <769ca2fb-b99c-a6a4-2559-5c12887d5e8a@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2016 at 09:00:33PM +0200, Jiri Slaby wrote: > On 07/21/2016, 08:56 PM, Greg KH wrote: > > On Thu, Jul 21, 2016 at 08:36:18AM +0200, Jiri Slaby wrote: > >> On 07/14/2016, 10:15 AM, Jiri Slaby wrote: > >>> From: Florian Westphal > >>> > >>> 3.12-stable review patch. If anyone has any objections, please let me know. > >>> > >>> =============== > >>> > >>> commit 36472341017529e2b12573093cc0f68719300997 upstream. > >> > >> I am now dropping this one. 3.12.62 will be released without that patch. > >> After the performance issue is resolved, it will be requeued. > > > > Personally, I think the bug fixes were more important than the > > performance issues at this point in time, but it's your call to make :) > > Ok, but to quote [1]: > iptables-restore will take forever (gave up after 10 minutes) > > I would say it proved itself not to be a performance issue, but rather a > functional issue :). Both Pablo and Florian suggested to postpone the patch. Even worse: because of a shared lock which is held for all this time, this allows (on kernel >= 3.8) an unprivileged user to block similar operation in all network namespaces including init_net. While a partial DoS like this is certainly better than allowing to crash the system, it could still be considered a security issue. Michal Kubecek