From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718AbcGYIDC (ORCPT ); Mon, 25 Jul 2016 04:03:02 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36437 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbcGYICs (ORCPT ); Mon, 25 Jul 2016 04:02:48 -0400 Date: Mon, 25 Jul 2016 10:02:45 +0200 From: Michal Hocko To: Guenter Roeck Cc: Andrew Morton , linux-kernel@vger.kernel.org, Johannes Weiner Subject: Re: [PATCH -next] mm: Drop unnecessary include file Message-ID: <20160725080245.GC9401@dhcp22.suse.cz> References: <1469339408-9240-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469339408-9240-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 23-07-16 22:50:08, Guenter Roeck wrote: > Commmit e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware > workingset code") adds '#include ' to This sha is linux-next specific. This means it is unstable and shouldn't be referred to in a commit message. The patch you are fixing is sitting in the Andrew's tree as mm-fix-vm-scalability-regression-in-cgroup-aware-workingset-code.patch I guess it can be just folded into the above patch. > include/linux/memcontrol.h. This results in the following build error > when building hexagon images. > > In file included from ./include/linux/memcontrol.h:32:0, > from ./include/linux/swap.h:8, > from ./arch/hexagon/include/asm/pgtable.h:27, > from mm/init-mm.c:9: > ./include/linux/mm.h:322:2: error: unknown type name 'pmd_t' > ./include/linux/mm.h:353:7: error: unknown type name 'pmd_t' > ./include/linux/mm.h:414:30: error: unknown type name 'pmd_t' > > The include file does not appear to be necessary, so just drop it. Yes that seems to be really the case. I have just run it through my compile testing scripts and it works fine. Unfortunatelly my all arch cross build test doesn't include hexagon. > Fixes: e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware workingset code") > Cc: Johannes Weiner > Signed-off-by: Guenter Roeck Acked-by: Michal Hocko Thanks! > --- > Build tested with all architectures. No related build failures observed. > > include/linux/memcontrol.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 2cf30455b25f..5d8ca6e02e39 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -29,7 +29,6 @@ > #include > #include > #include > -#include > > struct mem_cgroup; > struct page; > -- > 2.5.0 -- Michal Hocko SUSE Labs