From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbcGYJ21 (ORCPT ); Mon, 25 Jul 2016 05:28:27 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:53721 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbcGYJ2U (ORCPT ); Mon, 25 Jul 2016 05:28:20 -0400 Date: Mon, 25 Jul 2016 10:28:01 +0100 From: Russell King - ARM Linux To: Kwangwoo Lee Cc: Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Hyunchul Kim , linux-kernel@vger.kernel.org, Woosuk Chung Subject: Re: [PATCH RFC] arm64: mm: convert __dma_* routines to use start, size Message-ID: <20160725092801.GR1041@n2100.armlinux.org.uk> References: <1469432406-27548-1-git-send-email-kwangwoo.lee@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469432406-27548-1-git-send-email-kwangwoo.lee@sk.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 04:40:06PM +0900, Kwangwoo Lee wrote: > __dma_* routines have been converted to use start and size instread of > start and end addresses. The patch was origianlly for adding > __clean_dcache_area_poc() which will be used in pmem driver to clean > dcache to the PoC(Point of Coherency) in arch_wb_cache_pmem(). I'd suggest keeping to this terminology: area: takes a start and size range: takes a start and end So, if you want to change the parameters to take a start and size, the function should not contain "range" but should contain "area" in its name. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.