From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752350AbcGYMyT (ORCPT ); Mon, 25 Jul 2016 08:54:19 -0400 Received: from foss.arm.com ([217.140.101.70]:33377 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbcGYMyK (ORCPT ); Mon, 25 Jul 2016 08:54:10 -0400 Date: Mon, 25 Jul 2016 13:54:06 +0100 From: Brian Starkey To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-kernel@vger.kernel.org, Liviu.Dudau@arm.com Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector Message-ID: <20160725125406.GB13937@e106950-lin.cambridge.arm.com> References: <1469444148-19003-1-git-send-email-brian.starkey@arm.com> <20160725122504.GS1041@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20160725122504.GS1041@n2100.armlinux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Linux wrote: >On Mon, Jul 25, 2016 at 11:55:48AM +0100, Brian Starkey wrote: >> The connector shouldn't be registered until the rest of the whole device >> is set up, so that consistent state is presented to userspace. >> >> As drm_dev_register() now registers all of the connectors anyway, >> there's no need to explicitly do it in individual drivers so remove >> the calls to drm_connector_register()/drm_connector_unregister(). >> >> This allows componentised drivers to use tda998x without having racy >> initialisation. > >Is there a corresponding patch for armada-drm so that the cubox doesn't >regress? Has it already been merged? > A patch for armada-drm to do what? I should perhaps have explicitly mentioned that this change depends on e28cd4d0a223: "drm: Automatically register/unregister all connectors", which is in drm-next. Like my commit message says - after the above commit, all connectors are automatically registered in drm_dev_register() - so I don't anticipate any regression, but I don't have a cubox to test. armada-drm seems to be doing effectively the same thing as arm/hdlcd, which works fine after this patch with no other changes. Let me know if I've missed something; or if you are able to test on cubox that would be great. Thanks, Brian >-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ >FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up >according to speedtest.net. >