From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbcGYPIc (ORCPT ); Mon, 25 Jul 2016 11:08:32 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34495 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbcGYPIZ (ORCPT ); Mon, 25 Jul 2016 11:08:25 -0400 Date: Mon, 25 Jul 2016 17:08:21 +0200 From: Daniel Vetter To: Brian Starkey Cc: Russell King - ARM Linux , Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector Message-ID: <20160725150821.GB26853@phenom.ffwll.local> Mail-Followup-To: Brian Starkey , Russell King - ARM Linux , Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1469444148-19003-1-git-send-email-brian.starkey@arm.com> <20160725122504.GS1041@n2100.armlinux.org.uk> <20160725125406.GB13937@e106950-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160725125406.GB13937@e106950-lin.cambridge.arm.com> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 01:54:06PM +0100, Brian Starkey wrote: > Hi Russell, > > On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Linux wrote: > > On Mon, Jul 25, 2016 at 11:55:48AM +0100, Brian Starkey wrote: > > > The connector shouldn't be registered until the rest of the whole device > > > is set up, so that consistent state is presented to userspace. > > > > > > As drm_dev_register() now registers all of the connectors anyway, > > > there's no need to explicitly do it in individual drivers so remove > > > the calls to drm_connector_register()/drm_connector_unregister(). > > > > > > This allows componentised drivers to use tda998x without having racy > > > initialisation. > > > > Is there a corresponding patch for armada-drm so that the cubox doesn't > > regress? Has it already been merged? > > > > A patch for armada-drm to do what? > > I should perhaps have explicitly mentioned that this change depends > on e28cd4d0a223: "drm: Automatically register/unregister all > connectors", which is in drm-next. > > Like my commit message says - after the above commit, all connectors > are automatically registered in drm_dev_register() - so I don't > anticipate any regression, but I don't have a cubox to test. > > armada-drm seems to be doing effectively the same thing as arm/hdlcd, > which works fine after this patch with no other changes. > > Let me know if I've missed something; or if you are able to test on > cubox that would be great. Ack from my side on generally nuking drm_connector_register() from everywhere except truely hotplugged connectors like dp mst. It should keep working for everyone. Only exception is if there's a driver which calls drm_dev_register too early (before all connectors are probed), which would be a bug anyway. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch