From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059AbcGYQQn (ORCPT ); Mon, 25 Jul 2016 12:16:43 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40146 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbcGYQQl (ORCPT ); Mon, 25 Jul 2016 12:16:41 -0400 Date: Mon, 25 Jul 2016 17:16:32 +0100 From: Mark Brown To: Jan Glauber Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, "Steven J. Hill" , David Daney Message-ID: <20160725161632.GD11806@sirena.org.uk> References: <20160724210452.GB6345@sirena.org.uk> <20160725155122.GA2710@hardcore> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B4IIlcmfBL/1gGOG" Content-Disposition: inline In-Reply-To: <20160725155122.GA2710@hardcore> X-Cookie: Are you still an ALCOHOLIC? User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --B4IIlcmfBL/1gGOG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 25, 2016 at 05:51:22PM +0200, Jan Glauber wrote: > On Sun, Jul 24, 2016 at 10:04:52PM +0100, Mark Brown wrote: > > On Sat, Jul 23, 2016 at 12:42:55PM +0200, Jan Glauber wrote: > > > + depends on 64BIT && PCI && !CAVIUM_OCTEON_SOC > > This is a *weird* and most likely broken set of dependencies - why > > exclude this if we're on Octeon (or Octeon happens to have been enabled > > in a config)? > I agree that it looks weird, the reasoning is that we would like > to avoid making the driver depend on something like ARCH_THUNDER. Why? > So I made the driver depend on the things it actually uses > (PCI for probing and 64BIT because of readq/writeq) and don't care if it > compiles on other platforms too (like x86). The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST) && PCI && 64BIT (so that people on other platforms where the device will never actually appear don't get bothered by the prompt). > That said, I can remove the !CAVIUM_OCTEON_SOC, it compiles without > errors on MIPS too. Would that be ok? Sure. --B4IIlcmfBL/1gGOG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXljtfAAoJECTWi3JdVIfQjVkH/jG2sNoTg316YPftqoyNJGTq QRvQyyLpiK4NxsQe9lHNmNFJRA+CXl0EaXo5W+E8rEN5ZGOi40eZ7oWF4k7OskP+ MwlKTuLfEQmphwe7D4cL0lp7wNZp7KCPkWftDRiIL4q/vaqp/GZm2CbKFHJHK2OK ZdDSGqHSWDiSvh42QvuPjROYhOV6780OH+ejn87QOLK+h1R2fCYTMvBpjSB7d1je H7x+nkb9FG19E+debuoVTuM3xBX7vip2cR3Tj5WT2WG83hPuRuPGFg1yisLdGV5Q qQr8bWRpK8+xEdMKa5DKOZTOVbNkVPCaBD5NKPXBBWGhxAFmQSsDTtOPa8qQyrs= =Z0K1 -----END PGP SIGNATURE----- --B4IIlcmfBL/1gGOG--