From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753398AbcGYQUL (ORCPT ); Mon, 25 Jul 2016 12:20:11 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40170 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279AbcGYQUJ (ORCPT ); Mon, 25 Jul 2016 12:20:09 -0400 Date: Mon, 25 Jul 2016 17:20:01 +0100 From: Mark Brown To: Jan Glauber Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, "Steven J. Hill" , David Daney Message-ID: <20160725162001.GE11806@sirena.org.uk> References: <20160724210452.GB6345@sirena.org.uk> <20160725155122.GA2710@hardcore> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AbQceqfdZEv+FvjW" Content-Disposition: inline In-Reply-To: <20160725155122.GA2710@hardcore> X-Cookie: Are you still an ALCOHOLIC? User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AbQceqfdZEv+FvjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 25, 2016 at 05:51:22PM +0200, Jan Glauber wrote: > On Sun, Jul 24, 2016 at 10:04:52PM +0100, Mark Brown wrote: > > On Sat, Jul 23, 2016 at 12:42:55PM +0200, Jan Glauber wrote: > > > +#define PCI_DEVICE_ID_THUNDERX_SPI 0xa00b > > > +static const struct pci_device_id thunderx_spi_pci_id_table[] = { > > > + { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVICE_ID_THUNDERX_SPI) }, > > > + { 0, } > > > +}; > > The define for the device ID doesn't seem to be adding much here. > I find it more readable instead of PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, 0xa00b), > or did I miss your point? No, that's my point - I find myself wondering why there's a define half way down the file and what else is looking at the define other than the location a few lines below. --AbQceqfdZEv+FvjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXljwwAAoJECTWi3JdVIfQ71sH/0MFxLdDOXfeZ8xc94sQlP9y VBIW6LaouRhbxv+MruqikFNRj1FeNXK4Qv7ZH7hFQseJrC+WDEnVueWRe+EOmprf 4X/nF/UXhKZ6SWVHln31ZpyGPi9msPJYBsYa9JHtl16v/hXuvFygWTmGu6qs7RFg SX5Wlpb+genqBacPrmaA/5BdapKT/CKvjyYO89o8hBEVJ58aD4vR/bNkHAcaOmwU d50rvC4HRYM8+6JxQH7uf4H5dI6kybzK+TMOXis76xg+tofkjTiYDDBpGNtzD1UD tVwJbAZCY/QK0Y230/ZUWUh1EFYu+5l0/vOC25VooP+A9+ClhyhhFa67U+OvSrw= =9Gaw -----END PGP SIGNATURE----- --AbQceqfdZEv+FvjW--