From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbcGZAGA (ORCPT ); Mon, 25 Jul 2016 20:06:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49893 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbcGZAF5 (ORCPT ); Mon, 25 Jul 2016 20:05:57 -0400 Date: Mon, 25 Jul 2016 17:05:55 -0700 From: Andrew Morton To: Fabian Frederick Cc: Robert Jarzmik , Michal Marek , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing Message-Id: <20160725170555.fd4df28de067f2a689a2efc2@linux-foundation.org> In-Reply-To: <1469366898-1496-1-git-send-email-fabf@skynet.be> References: <1469366898-1496-1-git-send-email-fabf@skynet.be> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick wrote: > Commit 51193b76bfff > ("kbuild: forbid kernel directory to contain spaces and colons") > > makes it impossible to build kernel on default SD labels like > "SD Card" for instance. > > Makefile:133: *** main directory cannot contain spaces nor colons. Stop. > > User could rename directories but volume name is not always writable. > > This patch adds ability to do make force=1 for people > not interested in modules_install in this case but only testing. > > (Note that other options could go under ifndef force) That's a bit of a hack on a hack. 51193b76bfff said: : When the kernel path contains a space or a colon somewhere in the path : name, the modules_install target doesn't work anymore, as the path names : are not enclosed in double quotes. It is also supposed that and O= build : will suffer from the same weakness as modules_install. : : Instead of checking and improving kbuild to resist to directories : including these characters, error out early to prevent any build if the : kernel's main directory contains a space. What's involved in fixing this properly? Make the whole kbuild system operate correctly when there are spaces/colons in the pathname?