From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753523AbcGYSbF (ORCPT ); Mon, 25 Jul 2016 14:31:05 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:33688 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306AbcGYSa7 (ORCPT ); Mon, 25 Jul 2016 14:30:59 -0400 Date: Mon, 25 Jul 2016 14:30:55 -0400 From: Tejun Heo To: Tom Yan Cc: Hannes Reinecke , Sergei Shtylyov , Arnd Bergmann , Stephen Rothwell , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page Message-ID: <20160725183055.GD19588@mtj.duckdns.org> References: <14bd98eb08ddf86be28f558817bed3cd27c397cd.1469126217.git.tom.ty89@gmail.com> <2ed3f3aba21a4b815e9497e6aeba497280f9f333.1469126217.git.tom.ty89@gmail.com> <20160721212600.GF23759@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2016 at 05:50:18AM +0800, Tom Yan wrote: > As I've mentioned in the comment/message, there is no ATA command > needed to be sent to the device, since it only toggles a bit in > dev->flags. See that there is no ata_taskfile constructed in > ata_mselect_control(). But ata_mselect_caching() contructs a tf? -- tejun