From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753396AbcGYSwX (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jul 2016 14:52:23 -0400
Received: from mail-qk0-f196.google.com ([209.85.220.196]:35078 "EHLO
	mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752877AbcGYSwU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jul 2016 14:52:20 -0400
Date: Mon, 25 Jul 2016 14:52:18 -0400
From: Tejun Heo <tj@kernel.org>
To: zijun_hu@htc.com
Cc: akpm@linux-foundation.org, kuleshovmail@gmail.com,
        ard.biesheuvel@linaro.org, tangchen@cn.fujitsu.com,
        weiyang@linux.vnet.ibm.com, dev@g0hl1n.net,
        david@gibson.dropbear.id.au, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock.c: fix index adjustment error in
 __next_mem_range_rev()
Message-ID: <20160725185218.GG19588@mtj.duckdns.org>
References: <42A378E55677204FAE257FE7EED241CB7E8EF004@CN-MBX01.HTC.COM.TW>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42A378E55677204FAE257FE7EED241CB7E8EF004@CN-MBX01.HTC.COM.TW>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 25, 2016 at 07:34:12AM +0000, zijun_hu@htc.com wrote:
> Hi All,
>          There is a bug in mm/memblock.c
>          Could you review and phase-in this patch?
>          Thanks a lot
> 
> From 3abf1822d30f77f126bd7a3c09bb243d9c17a029 Mon Sep 17 00:00:00 2001
> From: zijun_hu <zijun_hu@htc.com>
> Date: Mon, 25 Jul 2016 15:06:57 +0800
> Subject: [PATCH] mm/memblock.c: fix index adjustment error in
> __next_mem_range_rev()
> 
> fix region index adjustment error when parameter type_b of
> __next_mem_range_rev() == NULL
> 
> Signed-off-by: zijun_hu <zijun_hu@htc.com>
> ---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index ac12489..b14973e 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1024,7 +1024,7 @@ void __init_memblock __next_mem_range_rev(u64 *idx, int nid, ulong flags,
>                                  *out_end = m_end;
>                         if (out_nid)
>                                  *out_nid = m_nid;
> -                         idx_a++;
> +                        idx_a--;

Looks good to me.  Do you happen to have a test case for this bug?

Thanks.

-- 
tejun