From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564AbcGYS4P (ORCPT ); Mon, 25 Jul 2016 14:56:15 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:34850 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbcGYS4N (ORCPT ); Mon, 25 Jul 2016 14:56:13 -0400 Date: Mon, 25 Jul 2016 14:56:11 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Dmitry Tarnyagin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] caif-hsi: Remove deprecated create_singlethread_workqueue Message-ID: <20160725185611.GH19588@mtj.duckdns.org> References: <20160725131057.GA751@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160725131057.GA751@Karyakshetra> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 06:40:57PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since the workitems are being used > on a packet tx/rx path. Hence, WQ_MEM_RECLAIM has been set to guarantee > forward progress under memory pressure. > > An ordered workqueue has been used since workitems &cfhsi->wake_up_work > and &cfhsi->wake_down_work cannot be run concurrently. > > Calls to flush_workqueue() before destroy_workqueue() have been dropped > since destroy_workqueue() itself calls drain_workqueue() which flushes > repeatedly till the workqueue becomes empty. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun