From: "Felipe F. Tonello" <eu@felipetonello.com>
To: linux-usb@vger.kernel.org
Cc: Felipe Balbi <balbi@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] usb: gadget: f_midi: fixed endianness when using wMaxPacketSize
Date: Tue, 26 Jul 2016 00:15:03 +0100 [thread overview]
Message-ID: <20160725231506.3426-2-eu@felipetonello.com> (raw)
In-Reply-To: <20160725231506.3426-1-eu@felipetonello.com>
USB spec specifies wMaxPacketSize to be little endian (as other properties),
so when using this variable in the driver we should convert to the current
CPU endianness if necessary.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
drivers/usb/gadget/function/f_midi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 58fc199a18ec..a83d852b1da5 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -362,7 +362,7 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
struct usb_request *req =
midi_alloc_ep_req(midi->out_ep,
max_t(unsigned, midi->buflen,
- bulk_out_desc.wMaxPacketSize));
+ le16_to_cpu(bulk_out_desc.wMaxPacketSize)));
if (req == NULL)
return -ENOMEM;
--
2.9.2
next prev parent reply other threads:[~2016-07-25 23:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 23:15 [PATCH 0/4] MIDI Function improvements Felipe F. Tonello
2016-07-25 23:15 ` Felipe F. Tonello [this message]
2016-07-26 1:51 ` [PATCH 1/4] usb: gadget: f_midi: fixed endianness when using wMaxPacketSize Baolin Wang
2016-08-10 11:24 ` Felipe Balbi
2016-08-11 8:37 ` Felipe Ferreri Tonello
2016-07-25 23:15 ` [PATCH 2/4] usb: gadget: f_midi: defaults buflen sizes to 512 Felipe F. Tonello
2016-08-10 11:25 ` Felipe Balbi
2016-08-11 8:34 ` Felipe Ferreri Tonello
2016-07-25 23:15 ` [PATCH 3/4] usb: gadget: f_midi: refactor state machine Felipe F. Tonello
2016-07-25 23:15 ` [PATCH 4/4] usb: gadget: f_midi: drop substreams when disabling endpoint Felipe F. Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725231506.3426-2-eu@felipetonello.com \
--to=eu@felipetonello.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®