From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758695AbcGZW0X (ORCPT ); Tue, 26 Jul 2016 18:26:23 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42056 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758677AbcGZW0S (ORCPT ); Tue, 26 Jul 2016 18:26:18 -0400 Date: Tue, 26 Jul 2016 15:26:17 -0700 (PDT) Message-Id: <20160726.152617.309548003660454771.davem@davemloft.net> To: colin.king@canonical.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time From: David Miller In-Reply-To: <1468321179-7647-1-git-send-email-colin.king@canonical.com> References: <1468321179-7647-1-git-send-email-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Jul 2016 15:26:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 12 Jul 2016 11:59:39 +0100 > From: Colin Ian King > > According to the HPT366 data sheet, PCI config space dword 0x40-0x43 > bits 11:8 specify the primary drive cmd_high_time, however, > currently just 3 bits of the 4 are being used because the mask > is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock > to be detected. > > Also add in missing space between switch and parenthesis to clean > up a checkpatch warning. > > Signed-off-by: Colin Ian King Applied.