From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755416AbcGZGsL (ORCPT ); Tue, 26 Jul 2016 02:48:11 -0400 Received: from mail.osadl.at ([92.243.35.153]:33669 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817AbcGZGsI (ORCPT ); Tue, 26 Jul 2016 02:48:08 -0400 Date: Tue, 26 Jul 2016 06:48:00 +0000 From: Nicholas Mc Guire To: Wolfram Sang Cc: Nicholas Mc Guire , Greg Kroah-Hartman , Wolfram Sang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: declare private functions static Message-ID: <20160726064800.GB30333@osadl.at> References: <1469474547-15592-1-git-send-email-hofrat@osadl.org> <20160725210418.GD1698@katana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160725210418.GD1698@katana> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote: > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote: > > Private functions in ks_hostif.c can be declared static. > > > > Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository") > > > > Signed-off-by: Nicholas Mc Guire > > Reviewed-by: Wolfram Sang > > drivers/staging/ks7010/ks7010_sdio.c and > drivers/staging/ks7010/ks_wlan_net.c have similar warnings in case you'd > like to fix those, too.) > the cases found regarding completion were: ./drivers/staging/ks7010/ks_hostif.c:80 treating signal case as success ./drivers/staging/ks7010/ks_wlan_net.c:109 treating signal case as success ./drivers/staging/ks7010/ks7010_sdio.c:901 treating signal case as success ./drivers/staging/ks7010/ks7010_sdio.c:929 treating signal case as success ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:383 treating signal case as success ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:247 treating signal case as success will be going through all of them in the next days. thx! hofrat