From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755301AbcGZH1e (ORCPT ); Tue, 26 Jul 2016 03:27:34 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37314 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbcGZH1c (ORCPT ); Tue, 26 Jul 2016 03:27:32 -0400 Date: Tue, 26 Jul 2016 09:27:29 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "H. Nikolaus Schaller" Cc: "Andrew F . Davis" , Ivaylo Dimitrov , Andrzej Hajda , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org Subject: Re: [PATCH] power:bq27xxx: 27000/10 read FLAGS register as single Message-ID: <20160726072729.GB29844@pali> References: <6ff28e18f78d1b9581cba5fd214fcc00e4a6d23a.1468858328.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6ff28e18f78d1b9581cba5fd214fcc00e4a6d23a.1468858328.git.hns@goldelico.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 18 July 2016 18:12:09 H. Nikolaus Schaller wrote: > The bq27000 and bq27010 have a single byte FLAGS register. > Other gauges have 16 bit FLAGS registers. > > For reading the FLAGS register it is sufficient to read the single > register instead of reading RSOC at the next higher address as > well and then ignore the high byte. > > This does not change functionality but optimizes i2c and hdq > traffic. > > Signed-off-by: H. Nikolaus Schaller Looks good, add my Acked-by. -- Pali Rohár pali.rohar@gmail.com