From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfag12864b: Remove deprecated create_singlethread_workqueue
Date: Tue, 26 Jul 2016 13:01:23 -0400 [thread overview]
Message-ID: <20160726170123.GW19588@mtj.duckdns.org> (raw)
In-Reply-To: <20160726165300.GA9430@Karyakshetra>
On Tue, Jul 26, 2016 at 10:23:00PM +0530, Bhaktipriya Shridhar wrote:
> @@ -257,7 +256,6 @@ void cfag12864b_disable(void)
> if (cfag12864b_updating) {
> cfag12864b_updating = 0;
> cancel_delayed_work(&cfag12864b_work);
> - flush_workqueue(cfag12864b_workqueue);
It should be converted to cancel_delayed_work_sync(); otherwise,
nothing guarantees that the work item is finished.
Thanks.
--
tejun
prev parent reply other threads:[~2016-07-26 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 16:53 Bhaktipriya Shridhar
2016-07-26 17:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726170123.GW19588@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=bhaktipriya96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®