From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932526AbcGZTPy (ORCPT ); Tue, 26 Jul 2016 15:15:54 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35703 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161038AbcGZTMG (ORCPT ); Tue, 26 Jul 2016 15:12:06 -0400 From: "Felipe F. Tonello" To: linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Baolin Wang , Michal Nazarewicz , Andrzej Pietrasiewicz Subject: [PATCH 2/9] usb: gadget: align buffer size when allocating for OUT endpoint Date: Tue, 26 Jul 2016 20:11:53 +0100 Message-Id: <20160726191200.18943-3-eu@felipetonello.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160726191200.18943-1-eu@felipetonello.com> References: <20160726191200.18943-1-eu@felipetonello.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using usb_ep_align() makes sure that the buffer size for OUT endpoints is always aligned with wMaxPacketSize (512 usually). This makes sure that no buffer has the wrong size, which can cause nasty bugs. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/u_f.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/u_f.c b/drivers/usb/gadget/u_f.c index 4bc7eea8bfc8..d1933b0b76c3 100644 --- a/drivers/usb/gadget/u_f.c +++ b/drivers/usb/gadget/u_f.c @@ -12,6 +12,7 @@ */ #include "u_f.h" +#include struct usb_request *alloc_ep_req(struct usb_ep *ep, int len, int default_len) { @@ -20,6 +21,8 @@ struct usb_request *alloc_ep_req(struct usb_ep *ep, int len, int default_len) req = usb_ep_alloc_request(ep, GFP_ATOMIC); if (req) { req->length = len ?: default_len; + if (usb_endpoint_dir_out(ep->desc)) + req->length = usb_ep_align(ep, req->length); req->buf = kmalloc(req->length, GFP_ATOMIC); if (!req->buf) { usb_ep_free_request(ep, req); -- 2.9.0