From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161006AbcGZU7S (ORCPT ); Tue, 26 Jul 2016 16:59:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58973 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753616AbcGZU7O (ORCPT ); Tue, 26 Jul 2016 16:59:14 -0400 Date: Tue, 26 Jul 2016 15:59:10 -0500 From: Josh Poimboeuf To: Jessica Yu Cc: Miroslav Benes , Petr Mladek , Jiri Kosina , Chris J Arges , Eugene Shatokhin , live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Fix issue with alternatives/paravirt patches Message-ID: <20160726205910.xxurq5ylcdh6w5kn@treble> References: <1469078640-26798-1-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1469078640-26798-1-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 26 Jul 2016 20:59:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2016 at 01:23:58AM -0400, Jessica Yu wrote: > Hi, > > A few months ago, Chris Arges reported a bug involving alternatives/paravirt > patching that was discussed here [1] and here [2]. To briefly summarize the > bug, patch modules that contained .altinstructions or .parainstructions > sections would break because these alternative/paravirt patches would be > applied first by the module loader (see x86 module_finalize()), then > livepatch would later clobber these patches when applying per-object > relocations. This lead to crashes and unpredictable behavior. > > One conclusion we reached from our last discussion was that we will > need to introduce some arch-specific code to address this problem. > This patchset presents a possible fix for the bug by adding a new > arch-specific arch_klp_init_object_loaded() function that by default > does nothing but can be overridden by different arches. > > To fix this issue for x86, since we can access a patch module's Elf > sections through mod->klp_info, we can simply delay the calls to > apply_paravirt() and apply_alternatives() to arch_klp_init_object_loaded(), > which is called after relocations have been written for an object. > In addition, for patch modules, .parainstructions and .altinstructions are > prefixed by ".klp.arch.${objname}" so that the module loader ignores them > and livepatch can apply them manually. > > Currently for kpatch, we don't support including jump table sections in > the patch module, and supporting .smp_locks is currently broken, so we > don't consider those sections (for now). > > I did some light testing with some patches to kvm and verified that the > original issue reported in [2] was fixed. > > Based on linux-next. For the series: Acked-by: Josh Poimboeuf -- Josh