From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbcG0GM5 (ORCPT ); Wed, 27 Jul 2016 02:12:57 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:33097 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752686AbcG0GMf (ORCPT ); Wed, 27 Jul 2016 02:12:35 -0400 Date: Wed, 27 Jul 2016 11:42:30 +0530 From: Bhaktipriya Shridhar To: Saeed Mahameed , Matan Barak , Leon Romanovsky Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue Message-ID: <20160727061229.GA16943@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces deprecated create_singlethread_workqueue(). This is the identity conversion. A dedicated workqueue has been used since mlx5e workqueue was created to handle all mlx5e specific tasks. This is in preparation for vxlan using the mlx5e workqueue in order to schedule port add/remove operations. WQ_MEM_RECLAIM has been set to guarantee forward progress under memory pressure. Can the workitems be executed concurrently? Are the workitems being used on a memory reclaim path? Signed-off-by: Bhaktipriya Shridhar --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index fd43929..1a96445 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3042,7 +3042,7 @@ static void *mlx5e_create_netdev(struct mlx5_core_dev *mdev) priv = netdev_priv(netdev); - priv->wq = create_singlethread_workqueue("mlx5e"); + priv->wq = alloc_ordered_workqueue("mlx5e", WQ_MEM_RECLAIM); if (!priv->wq) goto err_free_netdev; -- 2.1.4