From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754521AbcG0JUx (ORCPT ); Wed, 27 Jul 2016 05:20:53 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34817 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754357AbcG0JUt (ORCPT ); Wed, 27 Jul 2016 05:20:49 -0400 Date: Wed, 27 Jul 2016 14:50:43 +0530 From: Bhaktipriya Shridhar To: Greg Kroah-Hartman , "GeyslanG.Bem@Karyakshetra" , Michal Hocko , Vlastimil Babka , Geliang Tang , Saurabh Karajgaonkar , Mel Gorman , Masanari Iida Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Message-ID: <20160727092043.GA25086@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org alloc_ordered_workqueue replaces the deprecated create_singlethread_workqueue. The workqueue "workqueue" has multiple workitems which may require ordering. Hence, a dedicated ordered workqueue has been used. Since the workqueue is not being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set. Can the workitems run concurrently? Is the ordering among work items necessary? Thanks. Signed-off-by: Bhaktipriya Shridhar --- drivers/usb/host/u132-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c index 43d5293..cbde189 100644 --- a/drivers/usb/host/u132-hcd.c +++ b/drivers/usb/host/u132-hcd.c @@ -3206,7 +3206,7 @@ static int __init u132_hcd_init(void) if (usb_disabled()) return -ENODEV; printk(KERN_INFO "driver %s\n", hcd_name); - workqueue = create_singlethread_workqueue("u132"); + workqueue = alloc_ordered_workqueue("u132", 0); retval = platform_driver_register(&u132_platform_driver); return retval; } -- 2.1.4