From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbcG0Gcm (ORCPT ); Wed, 27 Jul 2016 02:32:42 -0400 Received: from ozlabs.org ([103.22.144.67]:54601 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751660AbcG0Gcd (ORCPT ); Wed, 27 Jul 2016 02:32:33 -0400 Date: Wed, 27 Jul 2016 16:32:31 +1000 From: Stephen Rothwell To: Tejun Heo Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Yan Subject: Re: linux-next: build warnings after merge of the libata tree Message-ID: <20160727163231.51e88384@canb.auug.org.au> In-Reply-To: <20160721144459.GA22680@htj.duckdns.org> References: <20160721152603.4cf94e55@canb.auug.org.au> <20160721144459.GA22680@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On Thu, 21 Jul 2016 10:44:59 -0400 Tejun Heo wrote: > > On Thu, Jul 21, 2016 at 03:26:03PM +1000, Stephen Rothwell wrote: > > Hi Tejun, > > > > After merging the libata tree, today's linux-next build (arm > > multi_v7_defconfig) produced these warning: > > > > drivers/ata/libata-scsi.c: In function 'ata_mselect_caching': > > drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] > > if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) { > > ^ > > drivers/ata/libata-scsi.c: In function 'ata_mselect_control': > > drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] > > if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) { > > ^ > > > > Introduced by commit > > > > 9b7844a8c34a ("libata-scsi: fix read-only bits checking in ata_mselect_*()") > > Already reverted the patch. Sorry about that. This patch is still in the libata tree (git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git#for-next) -- Cheers, Stephen Rothwell