From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163156AbcG0WSN (ORCPT ); Wed, 27 Jul 2016 18:18:13 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:43911 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162535AbcG0WSJ (ORCPT ); Wed, 27 Jul 2016 18:18:09 -0400 Date: Thu, 28 Jul 2016 00:18:04 +0200 From: Francois Romieu To: Chunhao Lin Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting. Message-ID: <20160727221804.GA3564@electric-eye.fr.zoreil.com> References: <1469637668-8751-1-git-send-email-hau@realtek.com> <1469637668-8751-2-git-send-email-hau@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469637668-8751-2-git-send-email-hau@realtek.com> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index 0e62d74..f07604f 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -1749,13 +1749,21 @@ static u32 __rtl8169_get_wol(struct rtl8169_private *tp) > static void rtl8169_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol) > { > struct rtl8169_private *tp = netdev_priv(dev); > + struct pci_dev *pdev = tp->pci_dev; Nit: you may directly use "struct device *d = &tp->pci_dev->dev;" -- Ueimor