From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759398AbcG1Dwn (ORCPT ); Wed, 27 Jul 2016 23:52:43 -0400 Received: from smtprelay0058.hostedemail.com ([216.40.44.58]:48928 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759024AbcG1Dwg (ORCPT ); Wed, 27 Jul 2016 23:52:36 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:46:150:153:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:3874:4321:4470:5007:6261:8660:10004:10400:10471:10848:10967:11026:11232:11473:11638:11639:11658:11914:11984:12043:12295:12296:12438:12517:12519:12555:12740:13069:13073:13148:13153:13228:13230:13255:13311:13357:13439:14096:14097:14181:14659:14721:21080:21212:21324:21434:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: jeans92_8ae16966dc719 X-Filterd-Recvd-Size: 2742 Date: Wed, 27 Jul 2016 23:52:33 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Josh Poimboeuf , Ingo Molnar , Linux Kernel Mailing List Subject: Re: warning: calling =?UTF-8?B?4oCYX19idWlsdGluX3JldHVybl9hZGRy?= =?UTF-8?B?ZXNz4oCZ?= with a nonzero argument is unsafe Message-ID: <20160727235233.6d64628b@grimm.local.home> In-Reply-To: References: <20160727215825.6d004899@grimm.local.home> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jul 2016 20:21:50 -0700 Linus Torvalds wrote: > On Wed, Jul 27, 2016 at 6:58 PM, Steven Rostedt wrote: > > On Wed, 27 Jul 2016 16:00:54 -0700 > > Linus Torvalds wrote: > >> > >> I can just add a > >> > >> KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,) > > > > I like this solution. > > Ok. Pushed out. As long as people are aware of this, and are hopefully > at least looking for potential alternatives, it's fine. I just looked at your patch. Would this work if you moved that KBUILD_CFLAGS to the tracing directory? Something like the below (never compiled or tested). This way we still get warnings from other users. Signed-off-by: Steven Rostedt --- diff --git a/Makefile b/Makefile index 393b615..d384848 100644 --- a/Makefile +++ b/Makefile @@ -620,7 +620,6 @@ include arch/$(SRCARCH)/Makefile KBUILD_CFLAGS += $(call cc-option,-fno-delete-null-pointer-checks,) KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) -KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,) ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE KBUILD_CFLAGS += -Os diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile index 979e7bf..48079dd 100644 --- a/kernel/trace/Makefile +++ b/kernel/trace/Makefile @@ -1,4 +1,7 @@ +# We are fully aware of the dangers of __builtin_return_address() > 0 +KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,) + # Do not instrument the tracer itself: ifdef CONFIG_FUNCTION_TRACER