mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nitin.m.gupta@oracle.com
Cc: akpm@linux-foundation.org, dingel@linux.vnet.ibm.com,
	schwidefsky@de.ibm.com, kirill.shutemov@linux.intel.com,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] sparc64: Fix pagetable freeing for hugepage regions
Date: Thu, 28 Jul 2016 21:00:48 -0700 (PDT)	[thread overview]
Message-ID: <20160728.210048.165773321219658930.davem@davemloft.net> (raw)
In-Reply-To: <1466719639-143815-2-git-send-email-nitin.m.gupta@oracle.com>

From: Nitin Gupta <nitin.m.gupta@oracle.com>
Date: Thu, 23 Jun 2016 15:05:36 -0700

> 8M pages now allocate page tables till PMD level only.
> So, when freeing page table for 8M hugepage backed region,
> make sure we don't try to access non-existent PTE level.
> 
> Signed-off-by: Nitin Gupta <nitin.m.gupta@oracle.com>

The manner in which you have submitted this change breaks
bisectability.

The "problem" you are fixing here is introduced by you in patch #1.

You need to combine these two changes together, otherwise there is
an intermediate state where the kernel is broken by your changes.

      reply	other threads:[~2016-07-29  4:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 22:05 [PATCH v2 1/2] sparc64: Trim page tables for 8M hugepages Nitin Gupta
2016-06-23 22:05 ` [PATCH v2 2/2] sparc64: Fix pagetable freeing for hugepage regions Nitin Gupta
2016-07-29  4:00   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160728.210048.165773321219658930.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=dingel@linux.vnet.ibm.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nitin.m.gupta@oracle.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®