From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163620AbcG1HDI (ORCPT ); Thu, 28 Jul 2016 03:03:08 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:59338 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162467AbcG1HC6 (ORCPT ); Thu, 28 Jul 2016 03:02:58 -0400 Date: Thu, 28 Jul 2016 03:02:45 -0400 From: Rich Felker To: Arnd Bergmann Cc: Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource: j-core: type fix init function return code Message-ID: <20160728070245.GA25280@brightrain.aerifal.cx> References: <20160726123140.878340-1-arnd@arndb.de> <20160727052533.GA6689@brightrain.aerifal.cx> <3868635.g1oGrAbjGg@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3868635.g1oGrAbjGg@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2016 at 10:00:50AM +0200, Arnd Bergmann wrote: > On Wednesday, July 27, 2016 1:25:33 AM CEST Rich Felker wrote: > > On Tue, Jul 26, 2016 at 02:31:29PM +0200, Arnd Bergmann wrote: > > > The CLOCKSOURCE_OF_DECLARE now takes a function that returns an 'int', but a this > > > new clocksource driver has just appeared in linux-next and causes a warning because > > > it has the old 'void' return value: > > > > > > In file included from ../include/linux/clocksource.h:18:0, > > > from ../include/linux/clockchips.h:13, > > > from ../drivers/clocksource/jcore-pit.c:14: > > > include/linux/of.h:1006:20: error: comparison of distinct pointer types lacks a cast [-Werror] > > > .data = (fn == (fn_type)NULL) ? fn : fn } > > > ^ > > > > > > This adapts the jcore_pit_init() function to the correct return type. > > > > > > Signed-off-by: Arnd Bergmann > > > Fixes: e0aa0655c60b ("clocksource: add J-Core timer/clocksource driver") > > > --- > > > The patch that introduces the warnign currently only exists in the linux-sh git > > > tree and showed up in linux-next this week. > > > > I've removed the commit from my for-next branch since it's not > > appropriate to go upstream through my tree. Your patch should still be > > applied in the proper subsystem tree, though, I think. Daniel? > > I think the way to do it now is to fold my patch into your driver and submit > it to the clocksource git on top of the API change. Done. Rich