From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753571AbcG1IWf (ORCPT ); Thu, 28 Jul 2016 04:22:35 -0400 Received: from foss.arm.com ([217.140.101.70]:47803 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbcG1IW2 (ORCPT ); Thu, 28 Jul 2016 04:22:28 -0400 Date: Thu, 28 Jul 2016 09:22:21 +0100 From: Brian Starkey To: Wei Yongjun , seanpaul@chromium.org Cc: Liviu Dudau , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Message-ID: <20160728082220.GA13322@e106950-lin.cambridge.arm.com> References: <1469672066-13401-1-git-send-email-weiyj.lk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1469672066-13401-1-git-send-email-weiyj.lk@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei, On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote: >Fix to return error code -EINVAL from the error handling >case instead of 0, as done elsewhere in this function. > >Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port >instead of the endpoint') >Signed-off-by: Wei Yongjun >--- Thanks for cleaning up after me! :-) Acked-by: Brian Starkey @Sean, can you pick this up on top of 3c31760e760c? Cheers, Brian > drivers/gpu/drm/arm/malidp_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c >index 4e61ea5..44b24cb 100644 >--- a/drivers/gpu/drm/arm/malidp_drv.c >+++ b/drivers/gpu/drm/arm/malidp_drv.c >@@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev) > > /* Set the CRTC's port so that the encoder component can find it */ > ep = of_graph_get_next_endpoint(dev->of_node, NULL); >- if (!ep) >+ if (!ep) { >+ ret = -EINVAL; > goto port_fail; >+ } > malidp->crtc.port = of_get_next_parent(ep); > > ret = component_bind_all(dev, drm); >