From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756767AbcG1K74 (ORCPT ); Thu, 28 Jul 2016 06:59:56 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35893 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755839AbcG1K7s (ORCPT ); Thu, 28 Jul 2016 06:59:48 -0400 Date: Thu, 28 Jul 2016 12:59:43 +0200 From: Daniel Vetter To: Liviu Dudau Cc: Wei Yongjun , Mali DP Maintainers , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Message-ID: <20160728105943.GJ6232@phenom.ffwll.local> Mail-Followup-To: Liviu Dudau , Wei Yongjun , Mali DP Maintainers , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1469671753-12961-1-git-send-email-weiyj.lk@gmail.com> <20160728081143.GD8609@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160728081143.GD8609@e106497-lin.cambridge.arm.com> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 09:11:43AM +0100, Liviu Dudau wrote: > On Thu, Jul 28, 2016 at 02:09:13AM +0000, Wei Yongjun wrote: > > There is a error message within devm_ioremap_resource > > already, so remove the DRM_ERROR call to avoid redundant > > error message. > > Yeah, good catch! > > > > > Signed-off-by: Wei Yongjun > > Acked-by: Liviu Dudau Applied to drm-misc, thanks. -Daniel > > > Thanks for the cleanup! > Liviu > > > --- > > drivers/gpu/drm/arm/malidp_drv.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > > index 4e61ea5..1160322 100644 > > --- a/drivers/gpu/drm/arm/malidp_drv.c > > +++ b/drivers/gpu/drm/arm/malidp_drv.c > > @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev) > > > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > hwdev->regs = devm_ioremap_resource(dev, res); > > - if (IS_ERR(hwdev->regs)) { > > - DRM_ERROR("Failed to map control registers area\n"); > > + if (IS_ERR(hwdev->regs)) > > return PTR_ERR(hwdev->regs); > > - } > > > > hwdev->pclk = devm_clk_get(dev, "pclk"); > > if (IS_ERR(hwdev->pclk)) > > > > -- > ==================== > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > ¯\_(ツ)_/¯ > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch