From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756846AbcG1LA2 (ORCPT ); Thu, 28 Jul 2016 07:00:28 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35653 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756249AbcG1LAW (ORCPT ); Thu, 28 Jul 2016 07:00:22 -0400 Date: Thu, 28 Jul 2016 13:00:18 +0200 From: Daniel Vetter To: Brian Starkey Cc: Wei Yongjun , seanpaul@chromium.org, Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Message-ID: <20160728110018.GK6232@phenom.ffwll.local> Mail-Followup-To: Brian Starkey , Wei Yongjun , seanpaul@chromium.org, Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1469672066-13401-1-git-send-email-weiyj.lk@gmail.com> <20160728082220.GA13322@e106950-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160728082220.GA13322@e106950-lin.cambridge.arm.com> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 09:22:21AM +0100, Brian Starkey wrote: > Hi Wei, > > On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote: > > Fix to return error code -EINVAL from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port > > instead of the endpoint') > > Signed-off-by: Wei Yongjun > > --- > > Thanks for cleaning up after me! :-) > > Acked-by: Brian Starkey Applied to drm-misc, thanks. -Daniel > > @Sean, can you pick this up on top of 3c31760e760c? > > Cheers, > Brian > > > drivers/gpu/drm/arm/malidp_drv.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > > index 4e61ea5..44b24cb 100644 > > --- a/drivers/gpu/drm/arm/malidp_drv.c > > +++ b/drivers/gpu/drm/arm/malidp_drv.c > > @@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev) > > > > /* Set the CRTC's port so that the encoder component can find it */ > > ep = of_graph_get_next_endpoint(dev->of_node, NULL); > > - if (!ep) > > + if (!ep) { > > + ret = -EINVAL; > > goto port_fail; > > + } > > malidp->crtc.port = of_get_next_parent(ep); > > > > ret = component_bind_all(dev, drm); > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch