From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbcG2Cao (ORCPT ); Thu, 28 Jul 2016 22:30:44 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34691 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbcG2Cam (ORCPT ); Thu, 28 Jul 2016 22:30:42 -0400 Date: Thu, 28 Jul 2016 19:30:39 -0700 From: Kees Cook To: Linus Torvalds Cc: Arnd Bergmann , Mark Rutland , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH] lkdtm: Fix targets for objcopy usage Message-ID: <20160729023039.GA15900@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The targets for lkdtm's objcopy were missing which caused them to always be rebuilt. This corrects the problem. Additionally, commit f8fa70f392fa ("arm64: localise Image objcopy flags") has landed now, so this removes the work-around for the global OBJCOPY flag setting. Reported-by: Linus Torvalds Signed-off-by: Kees Cook --- drivers/misc/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 4387ccb79e64..132f4e3462ba 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -65,9 +65,9 @@ lkdtm-$(CONFIG_LKDTM) += lkdtm_perms.o lkdtm-$(CONFIG_LKDTM) += lkdtm_rodata_objcopy.o lkdtm-$(CONFIG_LKDTM) += lkdtm_usercopy.o -OBJCOPYFLAGS := OBJCOPYFLAGS_lkdtm_rodata_objcopy.o := \ --set-section-flags .text=alloc,readonly \ --rename-section .text=.rodata -$(obj)/lkdtm_rodata_objcopy.o: $(obj)/lkdtm_rodata.o +targets += lkdtm_rodata.o lkdtm_rodata_objcopy.o +$(obj)/lkdtm_rodata_objcopy.o: $(obj)/lkdtm_rodata.o FORCE $(call if_changed,objcopy) -- 2.7.4 -- Kees Cook Brillo & Chrome OS Security