From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbcG2NR1 (ORCPT ); Fri, 29 Jul 2016 09:17:27 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:34737 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbcG2NRX (ORCPT ); Fri, 29 Jul 2016 09:17:23 -0400 Date: Fri, 29 Jul 2016 09:17:20 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: lvstest: Remove deprecated create_singlethread_workqueue Message-ID: <20160729131720.GN2542@mtj.duckdns.org> References: <20160728084511.GA11451@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160728084511.GA11451@Karyakshetra> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 02:15:11PM +0530, Bhaktipriya Shridhar wrote: > The workqueue has a single work item(&lvs->rh_work) and hence > doesn't require ordering. Also, it is not being used on a memory > reclaim path. Hence, the singlethreaded workqueue has been replaced > with the use of system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > The work item has been flushed in lvs_rh_disconnect() to ensure that > there are no pending tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun