From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753257AbcG2Qma (ORCPT ); Fri, 29 Jul 2016 12:42:30 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51968 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbcG2Qm2 (ORCPT ); Fri, 29 Jul 2016 12:42:28 -0400 Date: Fri, 29 Jul 2016 17:42:21 +0100 From: Mark Brown To: Maarten ter Huurne Cc: linux-kernel@vger.kernel.org Message-ID: <20160729164221.GK10376@sirena.org.uk> References: <1469803603-15862-1-git-send-email-maarten@treewalker.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m0XfRaZG5aslkcJX" Content-Disposition: inline In-Reply-To: <1469803603-15862-1-git-send-email-maarten@treewalker.org> X-Cookie: Tell me what to think!!! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: cache: Fix num_reg_defaults computation from reg_defaults_raw X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --m0XfRaZG5aslkcJX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 29, 2016 at 04:46:43PM +0200, Maarten ter Huurne wrote: > for (count = 0, i = 0; i < map->num_reg_defaults_raw; i++) > - if (!regmap_volatile(map, i * map->reg_stride)) > + if (regmap_readable(map, i * map->reg_stride) && > + !regmap_volatile(map, i * map->reg_stride)) This seems fine but please use a normal coding style, there's a *huge* amount of indentation on the second line for some reason. It should align with the ( in the if statement. --m0XfRaZG5aslkcJX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXm4dsAAoJECTWi3JdVIfQWwgH/A/kXrLHaeB9Z6BR5+8Q6zRG knk0lPPWmZ73dxmX7Z176AQ2LdlbF0jBM4mvRwaoC3RaNfXBT2S7mA/BuuEgYElw OphIFMuoeI3C5+HtVgJBC93uUR/2UI+yscQCGY7pj9SZ7jzG66ReLuOdT4S66deS 5pTxal/qqbVCh0SooGNgf6lpJ+VwB2TAd6hARDGmOlgyQnq+y+UQllgJ8XhJfznD G+Pz+9/vM91zvNhAOKh/dfltuM/zqHNED/JrrXB8/Kf6Djg5tK+maKXr+YlZZy2g +nHUsYtegDHuRUumD+JK+3x7YqrQVEK4P0yWSfXYlHfKjePoF70l8hKBMGUMvBI= =3ulf -----END PGP SIGNATURE----- --m0XfRaZG5aslkcJX--