From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752784AbcG3LK6 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 Jul 2016 07:10:58 -0400
Received: from foss.arm.com ([217.140.101.70]:56542 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752153AbcG3LKX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 Jul 2016 07:10:23 -0400
Date: Sat, 30 Jul 2016 12:10:21 +0100
From: Marc Zyngier <marc.zyngier@arm.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: John Stultz <john.stultz@linaro.org>, linus.walleij@linaro.org,
        Jon Hunter <jonathanh@nvidia.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] "irqdomain: Don't set type when mapping an IRQ"
 breaks nexus7 gpio buttons
Message-ID: <20160730121021.07a1964f@why.wild-wind.fr.eu.org>
In-Reply-To: <20160730045201.GB13516@tuxbot>
References: <CALAqxLUMMc_3cnj_0q9-hr+0ZKQONNyJKynT3RtsvOy4JKsDgQ@mail.gmail.com>
	<20160730045201.GB13516@tuxbot>
Organization: ARM Ltd
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 29 Jul 2016 21:52:01 -0700
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:

> On Fri 29 Jul 21:39 PDT 2016, John Stultz wrote:
> 
> > Hey Jon,
> >   So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I
> > noticed the power/volume buttons stopped working.
> >   
> 
> +Linus, as that's gpio-keys on top of two fairly standard gpio/pinctrl
> drivers (8064 TLMM and SSBI).
> 
> Regards,
> Bjorn
> 
> > I did a manual rebased bisection and chased it down to your commit
> > 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ").
> > 
> > Reverting that patch makes things work again, so I wanted to see if
> > there was any debugging info I could provide to try to help narrow
> > down the problem here. (Sorry, I'd tinker myself with it some and try
> > to debug the issue, but after burning my friday night on this, I'm
> > eager to get away from the keyboard for the weekend).

It feels either like a case of trigger information not being provided
through DT *and* not passed as arguments to request_irq (and friends),
or like a conflicting trigger.

Thanks,

	M.
-- 
Without deviation from the norm, progress is not possible.