From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753443AbcG3V6t (ORCPT ); Sat, 30 Jul 2016 17:58:49 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:49509 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbcG3V6l (ORCPT ); Sat, 30 Jul 2016 17:58:41 -0400 Date: Sat, 30 Jul 2016 23:58:36 +0200 From: Francois Romieu To: Salil Kapur Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Networking: Core: netpoll: Fixed a missing spin_unlock Message-ID: <20160730215836.GA22500@electric-eye.fr.zoreil.com> References: <1469840027-17057-1-git-send-email-salilkapur93@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469840027-17057-1-git-send-email-salilkapur93@gmail.com> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Salil Kapur : [...] > diff --git a/net/core/netpoll.c b/net/core/netpoll.c > index fc75c9e..9124f76 100644 > --- a/net/core/netpoll.c > +++ b/net/core/netpoll.c > @@ -386,8 +386,10 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb, > !vlan_hw_offload_capable(netif_skb_features(skb), > skb->vlan_proto)) { > skb = __vlan_put_tag(skb, skb->vlan_proto, vlan_tx_tag_get(skb)); > - if (unlikely(!skb)) > + if (unlikely(!skb)) { > + __netif_tx_unlock(txq); > break; > + } > skb->vlan_tci = 0; > } > Your kernel is outdated: __vlan_put_tag has disappeared from net/core/netpoll.c since 62749e2cb3c4a7da3eaa5c01a7e787aebeff8536 ("vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto") by Jiri Pirko somewhere in 2014. -- Ueimor