From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752352AbcHADdo (ORCPT ); Sun, 31 Jul 2016 23:33:44 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:39612 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbcHADdh (ORCPT ); Sun, 31 Jul 2016 23:33:37 -0400 Date: Sun, 31 Jul 2016 20:32:47 -0700 (PDT) Message-Id: <20160731.203247.112564519224260656.davem@davemloft.net> To: zyjzyj2000@gmail.com Cc: xypron.glpk@gmx.de, Dept-GELinuxNICDev@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] net: qlcnic: avoid superfluous assignement From: David Miller In-Reply-To: References: <1469959657-1342-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 31 Jul 2016 20:32:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhuyj Date: Mon, 1 Aug 2016 10:57:20 +0800 > Sorry. > An inline function will be inserted into the calling function. Why > "Assigning NULL to parmeter dcb has no effect outside of the > inlined function." ? It doesn't do anything to "dcb" in the calling function, that's not how inlining works. The inlined function behaves exactly as if it were called as a non-inline function from the perspective of side effects visible to the program.