From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756057AbcHBEpQ (ORCPT ); Tue, 2 Aug 2016 00:45:16 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60724 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbcHBEpN (ORCPT ); Tue, 2 Aug 2016 00:45:13 -0400 Date: Mon, 01 Aug 2016 21:39:06 -0700 (PDT) Message-Id: <20160801.213906.4719100211156764.davem@davemloft.net> To: hau@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] 8139too: fix system hang when there is a tx timeout event. From: David Miller In-Reply-To: <1470030330-13277-1-git-send-email-hau@realtek.com> References: <1470030330-13277-1-git-send-email-hau@realtek.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Aug 2016 21:39:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chunhao Lin Date: Mon, 1 Aug 2016 13:45:30 +0800 > If tx timeout event occur, kernel will call rtl8139_tx_timeout_task() to reset > hardware. But in this function, driver does not stop tx and rx function before > reset hardware, that will cause system hang. > > In this patch, add stop tx and rx function before reset hardware. > > Signed-off-by: Chunhao Lin Applied, thanks.