From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752612AbcHAJyV (ORCPT ); Mon, 1 Aug 2016 05:54:21 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:60317 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbcHAJyM (ORCPT ); Mon, 1 Aug 2016 05:54:12 -0400 Date: Mon, 1 Aug 2016 10:53:51 +0100 From: Richard Ipsum To: Josh Triplett Cc: Eric Wong , Christian Couder , git@vger.kernel.org, linux-kernel@vger.kernel.org, dborowitz@google.com, Omar Jarjur , Harry Lawrence Subject: Re: [ANNOUNCE] git-series: track changes to a patch series over time Message-ID: <20160801095351.GA27496@salo> References: <20160729064055.GB25331@x> <20160729101011.GA3469@salo> <20160801075554.GA22222@starla> <20160801085928.lw3ltdksyrjujutu@x> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160801085928.lw3ltdksyrjujutu@x> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 01:59:29AM -0700, Josh Triplett wrote: > On Mon, Aug 01, 2016 at 07:55:54AM +0000, Eric Wong wrote: [snip] > > > > I'm not convinced another format/standard is needed besides the > > email workflow we already use for git and kernel development. > > Not all projects use a patches-by-email workflow, or want to. To the > extent that tools and projects use some other workflow, standardizing > the format they use to store patch reviews (including per-line > annotations, approvals, test results, etc) seems preferable to having > each tool use its own custom format. I concur, for better or for worse many projects have abandoned mailing lists in favour of github, gerrit, gitlab and the like. The problem being, with the exception of gerrit, most of these tools store review data in sql databases, which is bad for obvious reasons. > > > I also see the reliance on an after-the-fact search engine > > (which can be tuned/replaced) as philosophically inline with > > what git does, too, such as not having rename tracking and > > doing delayed deltafication. > > Storing review data in git doesn't mean it needs to end up in the > history of the project itself; it can use after-the-fact annotations on > a commit. Exactly.