From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753919AbcHAN1M (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Aug 2016 09:27:12 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:35227 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753322AbcHAN1H (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Aug 2016 09:27:07 -0400
Date: Mon, 1 Aug 2016 15:27:04 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        Hillf Danton <hillf.zj@alibaba-inc.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Vlastimil Babka <vbabka@suse.cz>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, Minchan Kim <minchan@kernel.org>,
        Rik van Riel <riel@surriel.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on
 global reclaim
Message-ID: <20160801132703.GF13544@dhcp22.suse.cz>
References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com>
 <20160801131840.GE13544@dhcp22.suse.cz>
 <20160801132145.GA19395@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160801132145.GA19395@esperanza>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 01-08-16 16:21:45, Vladimir Davydov wrote:
> On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote:
> > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote:
> > > We must call shrink_slab() for each memory cgroup on both global and
> > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally
> > > changed that so that now shrink_slab() is only called with memcg != NULL
> > > on memcg reclaim. As a result, memcg-aware shrinkers (including
> > > dentry/inode) are never invoked on global reclaim. Fix that.
> > > 
> > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis")
> > 
> > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere.
> 
> I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's
> d71df22b55099.

But this sha is unstable. THe patch you are referring to is already
sitting in the Linus tree so please use his (stable sha instead).
-- 
Michal Hocko
SUSE Labs