From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbcHAOMD (ORCPT ); Mon, 1 Aug 2016 10:12:03 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38628 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbcHAOLz (ORCPT ); Mon, 1 Aug 2016 10:11:55 -0400 Date: Mon, 1 Aug 2016 10:11:39 -0400 From: Konrad Rzeszutek Wilk To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com Subject: Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary Message-ID: <20160801141139.GE21356@char.us.oracle.com> References: <1470051680-17273-1-git-send-email-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470051680-17273-1-git-send-email-jgross@suse.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote: > The default for the Xen hypervisor is to not enable VPMU in order to > avoid security issues. In this case the Linux kernel will issue the > message "Could not initialize VPMU for cpu 0, error -95" which looks > more like an error than a normal state. > > Change the message to something less scary in case the hypervisor > returns EOPNOTSUPP when trying to activate VPMU. > > Signed-off-by: Juergen Gross > --- > arch/x86/xen/pmu.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c > index 32bdc2c..e9d66fa 100644 > --- a/arch/x86/xen/pmu.c > +++ b/arch/x86/xen/pmu.c > @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu) > return; > > fail: > - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", > - cpu, err); > + if (err == -EOPNOTSUPP) > + pr_info_once("VPMU usage disabled due to Xen settings\n"); How about 'VPMU disabled by hypevisor.' > + else > + pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", > + cpu, err); > free_pages((unsigned long)xenpmu_data, 0); > } > > -- > 2.6.6 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel