From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819AbcHAStn (ORCPT ); Mon, 1 Aug 2016 14:49:43 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46792 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754578AbcHAStm (ORCPT ); Mon, 1 Aug 2016 14:49:42 -0400 Date: Mon, 1 Aug 2016 19:49:31 +0100 From: Mark Brown To: David Daney Cc: Jan Glauber , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, David Daney , "Steven J . Hill" Message-ID: <20160801184931.GB10376@sirena.org.uk> References: <20160728083144.16625-1-jglauber@cavium.com> <20160728083144.16625-3-jglauber@cavium.com> <20160801172838.GW10376@sirena.org.uk> <579F958F.9020508@caviumnetworks.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ytgo/kJyDF3J5kSH" Content-Disposition: inline In-Reply-To: <579F958F.9020508@caviumnetworks.com> X-Cookie: Tell me what to think!!! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ytgo/kJyDF3J5kSH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote: > On 08/01/2016 10:28 AM, Mark Brown wrote: > > On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote: > > > + p->clk = devm_clk_get(dev, NULL); > > > + if (IS_ERR(p->clk)) > > > + goto out_unmap; > > We're now just using the normal clock API which is good but I'm now > > unclear what is going to ensure that the clock is there - is there some > > other change elsewhere that I'm not aware of? > The clock is an integral part of the SoC and is always running, so it will > always be there. All we want to know is the frequency, which is supplied by > the device tree clock-bindings framework So there's something there that registers the clock? What is that thing on ACPI systems? --Ytgo/kJyDF3J5kSH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXn5m5AAoJECTWi3JdVIfQYjYH/R3pBuMNTYIrYttij+NOYtgW uTbY0IOR5Tz5dZJlZT3WDZhqr3aOCeu7YoExcGvAsSYOMwqeJ3ndNoVEFNRUc2ot BvqYai0hub+7Jx7BvCN+9Ka7uALVewnHgx42GNPY/onCKy/WgYzCBUoW3Mnq2IG2 PsS71qlAsFwiPGZt+6n86yoZdwWDCSJChrLwehH4YAR4kTRSp7ePpxS41qF612jN Z5nApioSXKDCX+rF+gY39GwTln60R3EfBwUtmANTtv6FRZWm9R37kWC7MZtD9P0I VUQG62n3RR7zQ4itI0fvGNhbHMB0m5kRkwSTofa9g+bgGMNQB6oAUPz/a9ajXVw= =Szk7 -----END PGP SIGNATURE----- --Ytgo/kJyDF3J5kSH--