From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755189AbcHBSKc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 14:10:32 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:50694 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755046AbcHBSKO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 14:10:14 -0400
Date: Tue, 02 Aug 2016 11:00:17 -0700 (PDT)
Message-Id: <20160802.110017.807651313555771477.davem@davemloft.net>
To: john.stultz@linaro.org
Cc: dsa@cumulusnetworks.com, lorenzo@google.com, mateusz.bajorski@nokia.com,
        linux-kernel@vger.kernel.org, guodong.xu@linaro.org,
        dimitrysh@google.com, chh@google.com, ejcaruso@google.com,
        romlem@google.com
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to
 fib_nl_newrule breaks Android userspace
From: David Miller <davem@davemloft.net>
In-Reply-To: <CALAqxLXq7-U9tOOSQHta2TwyV8OVZA4cU9zKK58yWKv7v8VwZA@mail.gmail.com>
References: <CALAqxLW1Ge5ZeCEBnP=+0cT1wjQUrXozQc0fEwtmmGs6UQ6eEg@mail.gmail.com>
	<fb4e3c33-b2d3-00f3-3f2d-dcc4a641d53f@cumulusnetworks.com>
	<CALAqxLXq7-U9tOOSQHta2TwyV8OVZA4cU9zKK58yWKv7v8VwZA@mail.gmail.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 02 Aug 2016 11:00:17 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: John Stultz <john.stultz@linaro.org>
Date: Tue, 2 Aug 2016 10:51:26 -0700

> Yea, it looks like they do in their tree w/ their uid based routing:
> https://android.googlesource.com/kernel/common.git/+/fd2cf795f3ab193752781be7372949ac1780d0ed%5E%21/
> 
> index 96161b8..ce19c5b 100644
> --- a/include/uapi/linux/fib_rules.h
> +++ b/include/uapi/linux/fib_rules.h
> @@ -49,6 +49,8 @@ enum {
>         FRA_TABLE,      /* Extended table id */
>         FRA_FWMASK,     /* mask for netfilter mark */
>         FRA_OIFNAME,
> +       FRA_UID_START,  /* UID range */
> +       FRA_UID_END,
>         __FRA_MAX
>  };
...
> Lorenzo/Rom: Fyi, you've got another upstream feature collision to work out.

It is very difficult for us to take Android networking bug reports
against upstream seriously as long as these kind of situations
continue to exist.

Just FYI...