From: Steven Rostedt <rostedt@goodmis.org>
To: Baole Ni <baolex.ni@intel.com>
Cc: paulmck@linux.vnet.ibm.com, josh@joshtriplett.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
m.chehab@samsung.com, gregkh@linuxfoundation.org,
m.szyprowski@samsung.com, kyungmin.park@samsung.com,
k.kozlowski@samsung.com, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com, mhocko@suse.com, tglx@linutronix.de,
vkuznets@redhat.com, pmladek@suse.com, tj@kernel.org,
jpoimboe@redhat.com
Subject: Re: [PATCH 1070/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 09:24:15 -0400 [thread overview]
Message-ID: <20160802092415.55a86ca7@gandalf.local.home> (raw)
In-Reply-To: <20160802121343.21455-1-baolex.ni@intel.com>
On Tue, 2 Aug 2016 20:13:43 +0800
Baole Ni <baolex.ni@intel.com> wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
NACK!
I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH.
-- Steve
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> kernel/rcu/rcuperf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 3cee0d8..3812e93 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -66,7 +66,7 @@ torture_param(bool, shutdown, false, "Shutdown at end of performance tests.");
> torture_param(bool, verbose, true, "Enable verbose debugging printk()s");
>
> static char *perf_type = "rcu";
> -module_param(perf_type, charp, 0444);
> +module_param(perf_type, charp, S_IRUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
>
> static int nrealreaders;
> @@ -102,7 +102,7 @@ static int rcu_perf_writer_state;
> #define RCUPERF_RUNNABLE_INIT 0
> #endif
> static int perf_runnable = RCUPERF_RUNNABLE_INIT;
> -module_param(perf_runnable, int, 0444);
> +module_param(perf_runnable, int, S_IRUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(perf_runnable, "Start rcuperf at boot");
>
> /*
prev parent reply other threads:[~2016-08-02 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 12:13 Baole Ni
2016-08-02 13:24 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802092415.55a86ca7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@redhat.com \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhocko@suse.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®