From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966550AbcHBNd6 (ORCPT ); Tue, 2 Aug 2016 09:33:58 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:58840 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966456AbcHBNZ3 (ORCPT ); Tue, 2 Aug 2016 09:25:29 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::::::::,RULES_HIT:2:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1535:1593:1594:1605:1606:1730:1747:1777:1792:2393:2553:2559:2562:2901:2915:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:3874:4117:4321:5007:6261:6742:7875:9040:10004:10848:10967:11026:11232:11473:11658:11914:12043:12198:12296:12438:12517:12519:12555:12740:13146:13230:13439:13868:14096:14097:14659:21080:21324:21433:30012:30034:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: lip70_2bd3c0400a45c X-Filterd-Recvd-Size: 6249 Date: Tue, 2 Aug 2016 09:24:59 -0400 From: Steven Rostedt To: Baole Ni Cc: paulmck@linux.vnet.ibm.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, mhocko@suse.com, tglx@linutronix.de, vkuznets@redhat.com, pmladek@suse.com, tj@kernel.org, jpoimboe@redhat.com Subject: Re: [PATCH 1072/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802092459.368e2bfd@gandalf.local.home> In-Reply-To: <20160802121353.21587-1-baolex.ni@intel.com> References: <20160802121353.21587-1-baolex.ni@intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 20:13:53 +0800 Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > kernel/rcu/tree.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index c7f1bc4..d93a882 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -114,13 +114,13 @@ LIST_HEAD(rcu_struct_flavors); > > /* Dump rcu_node combining tree at boot to verify correct setup. */ > static bool dump_tree; > -module_param(dump_tree, bool, 0444); > +module_param(dump_tree, bool, S_IRUSR | S_IRGRP | S_IROTH); > /* Control rcu_node-tree auto-balancing at boot time. */ > static bool rcu_fanout_exact; > -module_param(rcu_fanout_exact, bool, 0444); > +module_param(rcu_fanout_exact, bool, S_IRUSR | S_IRGRP | S_IROTH); > /* Increase (but not decrease) the RCU_FANOUT_LEAF at boot time. */ > static int rcu_fanout_leaf = RCU_FANOUT_LEAF; > -module_param(rcu_fanout_leaf, int, 0444); > +module_param(rcu_fanout_leaf, int, S_IRUSR | S_IRGRP | S_IROTH); > int rcu_num_lvls __read_mostly = RCU_NUM_LVLS; > /* Number of rcu_nodes at specified level. */ > static int num_rcu_lvl[] = NUM_RCU_LVL_INIT; > @@ -166,27 +166,27 @@ static int kthread_prio = CONFIG_RCU_KTHREAD_PRIO; > #else /* #ifdef CONFIG_RCU_KTHREAD_PRIO */ > static int kthread_prio = IS_ENABLED(CONFIG_RCU_BOOST) ? 1 : 0; > #endif /* #else #ifdef CONFIG_RCU_KTHREAD_PRIO */ > -module_param(kthread_prio, int, 0644); > +module_param(kthread_prio, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > /* Delay in jiffies for grace-period initialization delays, debug only. */ > > #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_PREINIT > static int gp_preinit_delay = CONFIG_RCU_TORTURE_TEST_SLOW_PREINIT_DELAY; > -module_param(gp_preinit_delay, int, 0644); > +module_param(gp_preinit_delay, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > #else /* #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_PREINIT */ > static const int gp_preinit_delay; > #endif /* #else #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_PREINIT */ > > #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_INIT > static int gp_init_delay = CONFIG_RCU_TORTURE_TEST_SLOW_INIT_DELAY; > -module_param(gp_init_delay, int, 0644); > +module_param(gp_init_delay, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > #else /* #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_INIT */ > static const int gp_init_delay; > #endif /* #else #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_INIT */ > > #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_CLEANUP > static int gp_cleanup_delay = CONFIG_RCU_TORTURE_TEST_SLOW_CLEANUP_DELAY; > -module_param(gp_cleanup_delay, int, 0644); > +module_param(gp_cleanup_delay, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > #else /* #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_CLEANUP */ > static const int gp_cleanup_delay; > #endif /* #else #ifdef CONFIG_RCU_TORTURE_TEST_SLOW_CLEANUP */ > @@ -396,24 +396,24 @@ static long blimit = 10; /* Maximum callbacks per rcu_do_batch. */ > static long qhimark = 10000; /* If this many pending, ignore blimit. */ > static long qlowmark = 100; /* Once only this many pending, use blimit. */ > > -module_param(blimit, long, 0444); > -module_param(qhimark, long, 0444); > -module_param(qlowmark, long, 0444); > +module_param(blimit, long, S_IRUSR | S_IRGRP | S_IROTH); > +module_param(qhimark, long, S_IRUSR | S_IRGRP | S_IROTH); > +module_param(qlowmark, long, S_IRUSR | S_IRGRP | S_IROTH); > > static ulong jiffies_till_first_fqs = ULONG_MAX; > static ulong jiffies_till_next_fqs = ULONG_MAX; > static bool rcu_kick_kthreads; > > -module_param(jiffies_till_first_fqs, ulong, 0644); > -module_param(jiffies_till_next_fqs, ulong, 0644); > -module_param(rcu_kick_kthreads, bool, 0644); > +module_param(jiffies_till_first_fqs, ulong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > +module_param(jiffies_till_next_fqs, ulong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > +module_param(rcu_kick_kthreads, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > /* > * How long the grace period must be before we start recruiting > * quiescent-state help from rcu_note_context_switch(). > */ > static ulong jiffies_till_sched_qs = HZ / 20; > -module_param(jiffies_till_sched_qs, ulong, 0644); > +module_param(jiffies_till_sched_qs, ulong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > static bool rcu_start_gp_advanced(struct rcu_state *rsp, struct rcu_node *rnp, > struct rcu_data *rdp);