From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966425AbcHBNdr (ORCPT ); Tue, 2 Aug 2016 09:33:47 -0400 Received: from smtprelay0163.hostedemail.com ([216.40.44.163]:48951 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966474AbcHBNZ3 (ORCPT ); Tue, 2 Aug 2016 09:25:29 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2895:2901:3138:3139:3140:3141:3142:3353:3622:3865:3866:3868:3871:3874:5007:6261:6742:7875:9040:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12555:12740:13439:14096:14097:14181:14659:14721:21080:21324:30012:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: thumb86_2d643b03f1711 X-Filterd-Recvd-Size: 3608 Date: Tue, 2 Aug 2016 09:25:10 -0400 From: Steven Rostedt To: Baole Ni Cc: paulmck@linux.vnet.ibm.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, mhocko@suse.com, tglx@linutronix.de, vkuznets@redhat.com, pmladek@suse.com, tj@kernel.org, jpoimboe@redhat.com Subject: Re: [PATCH 1073/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802092510.4d75a819@gandalf.local.home> In-Reply-To: <20160802121358.21653-1-baolex.ni@intel.com> References: <20160802121358.21653-1-baolex.ni@intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 20:13:58 +0800 Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > kernel/rcu/update.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c > index 3e888cd..ee6df8e 100644 > --- a/kernel/rcu/update.c > +++ b/kernel/rcu/update.c > @@ -449,8 +449,8 @@ EXPORT_SYMBOL_GPL(do_trace_rcu_torture_read); > int rcu_cpu_stall_suppress __read_mostly; /* 1 = suppress stall warnings. */ > static int rcu_cpu_stall_timeout __read_mostly = CONFIG_RCU_CPU_STALL_TIMEOUT; > > -module_param(rcu_cpu_stall_suppress, int, 0644); > -module_param(rcu_cpu_stall_timeout, int, 0644); > +module_param(rcu_cpu_stall_suppress, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > +module_param(rcu_cpu_stall_timeout, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > int rcu_jiffies_till_stall_check(void) > { > @@ -525,7 +525,7 @@ DEFINE_SRCU(tasks_rcu_exit_srcu); > > /* Control stall timeouts. Disable with <= 0, otherwise jiffies till stall. */ > static int rcu_task_stall_timeout __read_mostly = HZ * 60 * 10; > -module_param(rcu_task_stall_timeout, int, 0644); > +module_param(rcu_task_stall_timeout, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > static void rcu_spawn_tasks_kthread(void); > > @@ -820,9 +820,9 @@ static bool rcu_self_test; > static bool rcu_self_test_bh; > static bool rcu_self_test_sched; > > -module_param(rcu_self_test, bool, 0444); > -module_param(rcu_self_test_bh, bool, 0444); > -module_param(rcu_self_test_sched, bool, 0444); > +module_param(rcu_self_test, bool, S_IRUSR | S_IRGRP | S_IROTH); > +module_param(rcu_self_test_bh, bool, S_IRUSR | S_IRGRP | S_IROTH); > +module_param(rcu_self_test_sched, bool, S_IRUSR | S_IRGRP | S_IROTH); > > static int rcu_self_test_counter; >