From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966651AbcHBN0w (ORCPT ); Tue, 2 Aug 2016 09:26:52 -0400 Received: from smtprelay0241.hostedemail.com ([216.40.44.241]:43419 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966555AbcHBNZm (ORCPT ); Tue, 2 Aug 2016 09:25:42 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1183:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2901:3138:3139:3140:3141:3142:3353:3622:3865:3866:3868:3871:3874:4321:5007:6261:6742:7875:9040:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21324:30012:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pen89_3126a1006294c X-Filterd-Recvd-Size: 2859 Date: Tue, 2 Aug 2016 09:25:36 -0400 From: Steven Rostedt To: Baole Ni Cc: john.stultz@linaro.org, tglx@linutronix.de, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, mhocko@suse.com, vkuznets@redhat.com, pmladek@suse.com, tj@kernel.org, jpoimboe@redhat.com Subject: Re: [PATCH 1075/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802092536.20166281@gandalf.local.home> In-Reply-To: <20160802121409.21787-1-baolex.ni@intel.com> References: <20160802121409.21787-1-baolex.ni@intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 20:14:09 +0800 Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > kernel/time/clocksource.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c > index 56ece14..9656bb1 100644 > --- a/kernel/time/clocksource.c > +++ b/kernel/time/clocksource.c > @@ -972,12 +972,12 @@ sysfs_show_available_clocksources(struct device *dev, > /* > * Sysfs setup bits: > */ > -static DEVICE_ATTR(current_clocksource, 0644, sysfs_show_current_clocksources, > +static DEVICE_ATTR(current_clocksource, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, sysfs_show_current_clocksources, > sysfs_override_clocksource); > > -static DEVICE_ATTR(unbind_clocksource, 0200, NULL, sysfs_unbind_clocksource); > +static DEVICE_ATTR(unbind_clocksource, S_IWUSR, NULL, sysfs_unbind_clocksource); > > -static DEVICE_ATTR(available_clocksource, 0444, > +static DEVICE_ATTR(available_clocksource, S_IRUSR | S_IRGRP | S_IROTH, > sysfs_show_available_clocksources, NULL); > > static struct bus_type clocksource_subsys = {